Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor file actions panel #409

Merged
merged 11 commits into from
Nov 22, 2021
Merged

Refactor file actions panel #409

merged 11 commits into from
Nov 22, 2021

Conversation

flowbe
Copy link
Contributor

@flowbe flowbe commented Nov 18, 2021 •
edited
Loading

  • Finish refactor SelectFloatingPanelViewController
  • Resolve TODOs
  • Test

Fixes #407

@flowbe flowbe marked this pull request as ready for review November 19, 2021 11:16
@flowbe flowbe requested a review from a team November 19, 2021 11:17
@flowbe
Copy link
Contributor Author

flowbe commented Nov 19, 2021

UI bug: scenee/FloatingPanel#515

@flowbe flowbe force-pushed the refactor-file-actions-panel branch 2 times, most recently from e6cb282 to 26aee3c Compare November 22, 2021 11:01
flowbe added 11 commits November 22, 2021 13:43
@flowbe
Use compositional layout
11f050a 
Signed-off-by: Florentin Bekier <[email protected]>
@flowbe
Improve cell updates + available offline
f9bd4b0 
Signed-off-by: Florentin Bekier <[email protected]>
@flowbe
Clean code + update subclass
b9d52c1 
Signed-off-by: Florentin Bekier <[email protected]>
@flowbe
Finish refactor select floating panel
31500a9 
Signed-off-by: Florentin Bekier <[email protected]>
@flowbe
Fix available offline
cc96a28 
Signed-off-by: Florentin Bekier <[email protected]>
@flowbe
Refactor inits
84368dd 
Signed-off-by: Florentin Bekier <[email protected]>
@flowbe
Rename floating panel collection view cell
095fb25 
Signed-off-by: Florentin Bekier <[email protected]>
@flowbe
Remove TODOs
8afee84 
Signed-off-by: Florentin Bekier <[email protected]>
@flowbe
Fix safe area in preview
d20d4ce 
Signed-off-by: Florentin Bekier <[email protected]>
@flowbe
Fix drop box update
029b2ae 
Signed-off-by: Florentin Bekier <[email protected]>
@flowbe
Fix tuist
a910901 
Signed-off-by: Florentin Bekier <[email protected]>
@flowbe flowbe force-pushed the refactor-file-actions-panel branch from 26aee3c to a910901 Compare November 22, 2021 12:43
@PhilippeWeidmann PhilippeWeidmann merged commit e198067 into master Nov 22, 2021
@PhilippeWeidmann PhilippeWeidmann deleted the refactor-file-actions-panel branch November 22, 2021 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippeWeidmann PhilippeWeidmann PhilippeWeidmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor file actions panel
2 participants
@flowbe @PhilippeWeidmann